Conversation
The regex expression was not parsing the response correctly in `asn.py:get_nets_radb`. May issue seems to be the ipwhois data may have changed no long ends in <br> instead with \n.
I think unit test should be passing, fixed unit test so it passes. The following test test_asn:test__get_nets_radb was asserting an empty list [], but I think the data should be parseable.
remove deprecated (#230)
Added tests to make 100% code coverage again. Also updated coveragerc to show missing lines in the coverage report.
Changes from secynic.
Changes to test as suggest by the maintainer
Since 1.3b1 (released Oct 10, 2014) Sphinx has support for NumPy and Google style docstring support via sphinx.ext.napoleon extension. The sphinxcontrib.napoleon extension will continue to work with Sphinx <= 1.2. Signed-off-by: Stanislav Levin <[email protected]>
Make use of builtin sphinx napoleon extension
Fixed changes from code review.
Regex not parsing response in `asn.py`
Fixed ASNOrigin lookups (#216)
Fixed bug in KRNIC queries due to a change in their service (#243)
Add rdap lookups to the returned dictionary results
Fixed bug in experimental.bulk_lookup_rdap where only the last result was returned (#262 - ameidatou)
Update changes for #262
Fix deprecation warnings due to invalid escape sequences.
Fixed travis build warnings (#268)
Pinned requirements (#274)
Added ip_failed_total to bulk_lookup_rdap (#235)
Fixed bug in root and sub-entities not getting queried/data (#247)
236/ip gen utils
ipv4_generate_random and ipv6_generate_random docs (#236)
Fixed NIR datetime parsing issue if only date is returned (#284)
Create python-publish-test.yml
Create python-publish.yml
Increment version 1.2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.