Fix DND5E .rc command: display custom attribute values in check output #1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using .rc command with custom attributes (e.g., .st 长剑=4 then .rc 长剑), the modifier value was not displayed in the output, showing "9[d20] + = 13" instead of "9[d20] + 4 = 13". This fix adds a fallback to use the modifier value directly when GetDetailText() returns an empty string, which happens for custom attributes. Co-authored-by: Szzrain <[email protected]>
Copilot
AI
changed the title
[WIP] Fix bug with .st custom attribute value not displaying
Fix DND5E .rc command: display custom attribute values in check output
Nov 10, 2025
🚨 PR Title Needs FormattingThe title of this PR needs to be formatted correctly.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom attribute values set via
.stwere omitted from.rccheck output despite being included in calculations. Result showed9[d20] + = 13instead of9[d20] + 4 = 13.Changes
dice/ext_dnd5e.go: Add fallback to display modifier value whenGetDetailText()returns empty stringThe VM's
GetDetailText()returns empty for simple attribute lookups but has values for complex expressions. This preserves existing detail text behavior while properly formatting custom attributes.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.