[fix] redirect when saving preferences #2760
Conversation
Erroneously commit 87e4c47 droped the 302 redirect. Signed-off-by: Markus Heiser <[email protected]>
This patch is an addition to PR #2656 which removed all usage of `base_url` from the templates, except one was forgotten in the cookie URL of the preferences. closes: 2740 Signed-off-by: Markus Heiser <[email protected]>
|
The problems with PR #2656 had several causes and the discussion is a little bit spread
To summarize: PR #2656 fixes a issue with a function which generates URLs and is used in several HTML templates. But PR #2656 has a bug and as additional, there have been left a wrong URL generating in the HTML template. Complex constellation and hard to describe with my poor english / to shorten up: PR #2656 fixes a real bug and this PR #2760 polish up to get rid of followup issues (discussed in the comments linked above). |
|
Finally got around to testing this, and it looks good! It works on local testing and on my public instance, including on my fork (see the merge-2760 branch. My merge-2760 branch also has #2716 merged and the suggestions also still work. |
|
@BBaoVanC thanks million times for your efforts! .. PR #2656 made some central changes in the way URLs are generated (the method before was a little bit buggy and inconsistent), this has had an impact on many positions where URLs are used. Your test has now convinced me that I have found and repaired all the positions. BTW: as normal contributors (like me and you), we are also able to approve a PR at github, this signals the maintainers, that a PR is well tested by the users. |
|
Well, I cannot reopen the PR using GH. I assume you can recreate the branch and reopen the PR. |
|
@return42 could you recreate the PRs then please? |
|
FYI: restored branch |
What does this PR do?
Since #2656 has been merged, we have issues with:
Why is this change important?
base_urlin the HTML template of the preferences-pageHow to test this PR locally?
Open preferences,
Related issues
closes: #2740