Changelog: #1
Merged
Changelog: #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address failures with recent macOS builds 1. Unix98 PTY (lines 26-85) - Uses /dev/ptmx with grantpt() - This is what macOS needs 2. openpty() (lines 87-125) - Alternative modern method 3. BSD fallback (lines 127+) - Old /dev/ptyXY style - This is what's being used (doesn't work on macOS) ⏺ The meson build doesn't check for HAVE_GRANTPT or HAVE_OPENPTY, so the code falls back to the old BSD pty method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address failures with recent macOS builds
⏺ The meson build doesn't check for HAVE_GRANTPT or HAVE_OPENPTY, so the code falls back to the old BSD pty method.