Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@samchungy
Copy link
Contributor

@samchungy samchungy commented Oct 23, 2025

Findings from skuba migration shenangians

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2025

🦋 Changeset detected

Latest commit: 4aeef77

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sku-lib/codemod Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@samchungy samchungy marked this pull request as ready for review October 31, 2025 04:03
@samchungy samchungy requested a review from a team as a code owner October 31, 2025 04:03
@samchungy
Copy link
Contributor Author

This isn't urgent, happy to wait for Adam to be back

Copy link
Contributor

@williamlark williamlark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add a test for it too, please? 🧪

@samchungy
Copy link
Contributor Author

Looks good. Can you add a test for it too, please? 🧪

I would if there were an existing set 🥲. I'll look into adding a testing suite when I have more time

@williamlark
Copy link
Contributor

There should be some in the sku-codemods.test.ts file.

@samchungy
Copy link
Contributor Author

sku-codemods.test.ts

touche, I'm blind. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants