This repository was archived by the owner on Jan 17, 2021. It is now read-only.
Fix registration scope #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ develop #18 diff @@
====================================
Files 23 23
Lines 490 490
Methods 9 9
Messages 0 0
Branches 64 64
====================================
Hits 490 490
Misses 0 0
Partials 0 0
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in this template
If fixing bugs:
Unable to test.
Description
In this PR, we force the worker registration to use
scope: location.pathnameto ensure current page is under controlling.Types of changes
Does this PR introduce a breaking change?