Fix updating the GitHub Status as soon as any TC task fails #24811
Conversation
|
@bors-servo r+ |
|
📌 Commit 5694aaf has been approved by |
Fix updating the GitHub Status as soon as any TC task fails … rather than only when the entire task group is resolved. This allows Homu to more quickly be notified of a failure, and move on to the next PR in the queue sooner. (Plus drive-by Brewfile fix.)
|
💔 Test failed - status-taskcluster |
|
Something I'm not excited about: when a failure happens during the WPT tests, it causes any unscheduled tasks to fail when they become scheduled later. This occurs because the git revision is no longer available, and makes it much more tedious to find the actual WPT failures, since there are 30 mac WPT tasks that could fail and you need to click through the logs to each of them. |
ac488cd to
21d6473
Compare
This should be deployed when servo/servo#24811 lands
21d6473 to
5472488
Compare
|
That’s a good point. I’ve added a few commits that try to solve this by making most tasks not use git at all. Instead they download a tarball of the repository’s contents from a (new) artifact of the decision task. Note that landing this alone will likely break daily tasks until servo/taskcluster-config#14 is deployed. (But deploying it without this PR landing likely also breaks them.) @bors-servo try |
Fix updating the GitHub Status as soon as any TC task fails … rather than only when the entire task group is resolved. This allows Homu to more quickly be notified of a failure, and move on to the next PR in the queue sooner. (Plus drive-by Brewfile fix.)
|
💔 Test failed - status-taskcluster |
|
@bors-servo try |
Fix updating the GitHub Status as soon as any TC task fails … rather than only when the entire task group is resolved. This allows Homu to more quickly be notified of a failure, and move on to the next PR in the queue sooner. (Plus drive-by Brewfile fix.)
|
💔 Test failed - status-taskcluster |
|
That's clever, and should also improve the situation where try builds can stomp on each other if a new one is launched before the build step for the previous one is complete. |
|
6 jobs failed because Or we can use a git bundle instead of a tarball and still get a git repository without relying of ephemeral GitHub branches. |
|
@bors-servo retry 54a9df64f1476dd12020019d7cf22ac34d727bc0 matches https://build.servo.org/builders/linux-rel-wpt/builds/14235/steps/shell__4/logs/filtered-wpt-errorsummary.log and #24750 (comment), so it might be the hash of a blank (white) PNG. #24726 ? |
|
💣 Failed to start rebuilding: |
Fix updating the GitHub Status as soon as any TC task fails … rather than only when the entire task group is resolved. This allows Homu to more quickly be notified of a failure, and move on to the next PR in the queue sooner. (Plus drive-by Brewfile fix.)
|
💔 Test failed - status-taskcluster |
|
@bors-servo retry #24726 |
Fix updating the GitHub Status as soon as any TC task fails … rather than only when the entire task group is resolved. This allows Homu to more quickly be notified of a failure, and move on to the next PR in the queue sooner. (Plus drive-by Brewfile fix.)
|
☀️ Test successful - status-taskcluster |
This should be deployed when servo/servo#24811 lands
This should be deployed when servo/servo#24811 lands
This should be deployed when servo/servo#24811 lands
This should be deployed when servo/servo#24811 lands
This is a follow up from 203a06f (PR servo#24811). The old instructions lead to the following error: ``` $ brew bundle install --file=etc/taskcluster/macos/Brewfile-gstreamer Error: No Brewfile found ```
Update README with new brew bundle file This is a follow up from 203a06f (PR #24811). The old instructions lead to the following error: ``` $ brew bundle install --file=etc/taskcluster/macos/Brewfile-gstreamer Error: No Brewfile found ``` <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because this is just an update to the README <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
… rather than only when the entire task group is resolved. This allows Homu to more quickly be notified of a failure, and move on to the next PR in the queue sooner.
(Plus drive-by Brewfile fix.)