Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@imatiach-msft
Copy link
Collaborator

#1042

For some reason I can't reproduce this issue locally. The objective is populated on the model.

@slundberg
Copy link
Collaborator

Thanks for digging into this @imatiach-msft ! Feel free to merge this or the other PR whenever you can verify it fixes it :)

@imatiach-msft
Copy link
Collaborator Author

@slundberg I was able to reproduce the issue when using the non-sklearn API from lightgbm. There might be other cases where this happens as well (maybe save/reload model?). I added more test coverage for the non-sklearn API. The current fix does seem to resolve the issue for non-sklearn API so I think it can be merged.

@DawidDabkowski
Copy link

Hello! Is there a chance of reviving this Pull Request and merging with Shap? It'd be great to solve this bug, I just ran into this issue on my current project.

@j-adamczyk
Copy link

Any update on this @slundberg @imatiach-msft? This is a pretty SHAP-breaking bug for me.

@github-actions
Copy link

github-actions bot commented Oct 3, 2024

We appreciate your contribution! This Pull Request has been inactive for two years, so it's been automatically marked as 'stale'.

Please leave a comment if you would still like the PR to remain open, and the 'stale' label will be removed.

Otherwise, if there is no activity in the next 90 days the PR will be closed.

@github-actions github-actions bot added the stale Indicates that there has been no recent activity on an issue label Oct 3, 2024
@github-actions
Copy link

github-actions bot commented Jan 1, 2025

This PR has been automatically closed due to a lack of recent activity.

We welcome your contributions! If your patch is still relevant, please don't hesitate to open a new PR.

@github-actions github-actions bot closed this Jan 1, 2025
@connortann connortann added todo Indicates issues that should be excluded from being marked as stale and removed stale Indicates that there has been no recent activity on an issue labels Jan 28, 2025
@connortann connortann reopened this Jan 28, 2025
@CloseChoice
Copy link
Collaborator

I cannot reproduce the issue on the latest master but I don't see any harm in here and it adds more tests, which I think, is a plus. Therefore I'll merge this ;)

@CloseChoice CloseChoice merged commit d66b56e into shap:master Sep 25, 2025
16 of 17 checks passed
@CloseChoice CloseChoice mentioned this pull request Sep 25, 2025
2 tasks
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.67%. Comparing base (11af84a) to head (ffcfd69).
⚠️ Report is 31 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1063   +/-   ##
=======================================
  Coverage   65.67%   65.67%           
=======================================
  Files          94       94           
  Lines       13134    13134           
=======================================
  Hits         8626     8626           
  Misses       4508     4508           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

todo Indicates issues that should be excluded from being marked as stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants