Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@connortann
Copy link
Collaborator

@connortann connortann commented Nov 29, 2023

Overview

Closes #3305

  • Adds support for 3.12
  • Remove support for 3.8
  • Excludes catboost and tensorflow from the 3.12 test suite (pending support)

Discussion

This brings us closer in line with the scientific python standard SPEC 0, which defines the recommended drop schedule for python versions:

On Apr 14, 2023 drop support for Python 3.8 (initially released on Oct 14, 2019)

See previous discussion on drop timelines: #3057

@connortann connortann mentioned this pull request Feb 5, 2024
4 tasks
@connortann connortann changed the title WIP: Add support for python 3.12 WIP: Add support for python 3.12, drop support for 3.8 Feb 5, 2024
@connortann connortann added BREAKING Indicates that a PR is introducing a breaking change enhancement Indicates new feature requests dependencies Pull requests that update a dependency file labels Feb 5, 2024
@connortann connortann marked this pull request as ready for review February 5, 2024 12:36
@connortann connortann added this to the 0.45.0 milestone Feb 5, 2024
@connortann connortann changed the title WIP: Add support for python 3.12, drop support for 3.8 Add support for python 3.12, drop support for 3.8 Feb 5, 2024
@connortann connortann requested a review from dsgibbons February 5, 2024 14:32
@codecov
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@d414e6a). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3414   +/-   ##
=========================================
  Coverage          ?   59.23%           
=========================================
  Files             ?       90           
  Lines             ?    12728           
  Branches          ?        0           
=========================================
  Hits              ?     7540           
  Misses            ?     5188           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@CloseChoice CloseChoice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@connortann connortann merged commit 79ab8fc into master Feb 6, 2024
@connortann connortann deleted the py312 branch February 6, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BREAKING Indicates that a PR is introducing a breaking change dependencies Pull requests that update a dependency file enhancement Indicates new feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH: Support python 3.12

3 participants