Fix use of Falcon language model for text generation #3592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connortann
reviewed
Mar 28, 2024
connortann
approved these changes
Mar 28, 2024
Collaborator
connortann
left a comment
There was a problem hiding this comment.
This looks great. Apologies for the rather slow response - I've been away for most of the past week.
I'll rename the title to something a bit more descriptive, to help the release notes.
connortann
reviewed
Mar 28, 2024
connortann
requested changes
Mar 28, 2024
Collaborator
connortann
left a comment
There was a problem hiding this comment.
Pending tests passing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3592 +/- ##
==========================================
+ Coverage 61.54% 61.66% +0.11%
==========================================
Files 90 90
Lines 12717 12721 +4
==========================================
+ Hits 7827 7844 +17
+ Misses 4890 4877 -13 ☔ View full report in Codecov by Sentry. |
CloseChoice
commented
Apr 3, 2024
connortann
approved these changes
Apr 5, 2024
Collaborator
connortann
left a comment
There was a problem hiding this comment.
LGTM!
Looks like a test failed due to a dependency install issue, which might be a transient network issue. I've retriggered that job, hopefully it will pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #3589
Description of the changes proposed in this pull request:
position_idsso we check the function signature dynamically now and only hand over the expected arguments to avoid errorsChecklist