Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@CloseChoice
Copy link
Collaborator

Overview

Closes #3579

Description of the changes proposed in this pull request:

  • initialize base_score for xgboost
  • add test

Checklist

  • All pre-commit checks pass.
  • Unit tests added (if fixing a bug or adding a new feature)

@CloseChoice CloseChoice requested a review from connortann April 18, 2024 17:01
@CloseChoice
Copy link
Collaborator Author

@connortann would be nice if we could get a new hotfix release when this is merged, since it seems to be needed by the community

@connortann connortann added this to the 0.45.1 milestone Apr 29, 2024
@connortann connortann added the bug Indicates an unexpected problem or unintended behaviour label Apr 29, 2024
@CloseChoice
Copy link
Collaborator Author

hmm, seems like our macos pipeline is failing due to xgboost errors. Haven't we had this before?

Copy link
Collaborator

@connortann connortann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@connortann connortann merged commit e2a4a47 into shap:master Apr 30, 2024
@CloseChoice CloseChoice deleted the xgboost-base-score-3579 branch May 1, 2024 00:28
@connortann connortann mentioned this pull request May 3, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Indicates an unexpected problem or unintended behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: base_score attribute of the XGBTreeModelLoader is broken for all exponential losses (e.g. tweedie, poisson)

2 participants