Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@operte
Copy link
Contributor

@operte operte commented Jul 14, 2024

Overview

Description of the changes proposed in this pull request:

I found some typos in the indices of the columns in the "Understanding Tree SHAP for Simple Models" notebook. If I understood the notebook correctly, the indices should now be coherent with the trees and the main text.

Related to #3036

Checklist

  • All pre-commit checks pass.
  • Unit tests added (if fixing a bug or adding a new feature)
  • Documentation renders correctly locally
  • Documentation renders correctly on PR build

@operte
Copy link
Contributor Author

operte commented Jul 14, 2024

I did something wrong with my installation of graphviz, so all the images were regenerated. There's no specified graphviz version on pyproject.toml. Is it ok that the figures have been regenerated? Otherwise I can try to install the same version as the previous changes and regenerate the notebook.

@operte operte force-pushed the doc/fix-indices-understanding-treeshap branch from 3877c74 to d3807aa Compare July 14, 2024 09:38
@operte operte marked this pull request as ready for review July 14, 2024 17:44
@operte operte changed the title DOCS: Fix column indices on Understanding Tree SHAP notebook DOCS: Fix column indices in Understanding Tree SHAP notebook Jul 15, 2024
@connortann connortann added the documentation Relating to readthedocs, notebooks, and exposition in docstrings label Jul 15, 2024
Copy link
Collaborator

@connortann connortann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great PR!

@connortann connortann merged commit f36bfaf into shap:master Jul 15, 2024
@operte operte deleted the doc/fix-indices-understanding-treeshap branch July 16, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Relating to readthedocs, notebooks, and exposition in docstrings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants