fix logit errors for 0 and 1 probas #3917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connortann
reviewed
Dec 10, 2024
connortann
reviewed
Dec 10, 2024
connortann
approved these changes
Dec 10, 2024
Collaborator
connortann
left a comment
There was a problem hiding this comment.
Approved, with two minor suggestions
Co-authored-by: connortann <[email protected]>
Co-authored-by: connortann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #3912
Description of the changes proposed in this pull request:
We clip the probabilities before passing them into a logit. This can be interpreted as doubting that the model is so sure that it really assigns the probabilities 0 and 1 to single observations and fixes the calculation of shap values using the kernelexplainer.
Checklist