Fix summary_plot displays only one feature 4081 #4087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4087 +/- ##
==========================================
+ Coverage 64.99% 65.07% +0.07%
==========================================
Files 93 93
Lines 12913 12912 -1
==========================================
+ Hits 8393 8402 +9
+ Misses 4520 4510 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Open
4 tasks
ParagEkbote
pushed a commit
to ParagEkbote/shap
that referenced
this pull request
May 29, 2025
* fix summary_plot * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #4081
Description of the changes proposed in this pull request:
summary_legacyrecursively we cannot reset the plot on each iteration, therefore remove the fix to BUG: Duplicate Color Bars inshap.summary_plotwhen Called Multiple Times in a Single Session #3920.test_summary_plot.pyfile and move its content totest_summary.py.shap.summary_plotwhen Called Multiple Times in a Single Session #3920 and let it xfail.Unfortunately I believe this opens BUG: Duplicate Color Bars in
shap.summary_plotwhen Called Multiple Times in a Single Session #3920 again.Checklist