Allowed font_style to be an array #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows multiple `font_style`s to be used, allowing, say, for a bold and italic text. Fixes sharkdp#49
sharkdp
reviewed
Jan 2, 2024
This allows multiple `font_style`s to be used, allowing, say, for a bold and italic text. Fixes sharkdp#49
4d2cdb9 to
cd2298e
Compare
…nto multiple_font_styles
This removes a trailing semicolon that can occur in some positions
sharkdp
reviewed
Jan 16, 2024
Comment on lines
+60
to
+66
| for (i, style) in self.0.iter().enumerate() { | ||
| if i + 1 == self.0.len() { | ||
| write!(f, "{}", style)?; | ||
| } else { | ||
| write!(f, "{};", style)?; | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
Would it be possible to use https://doc.rust-lang.org/std/primitive.slice.html#method.join here?
Contributor
Author
There was a problem hiding this comment.
Nope, because that would only work if the slice was a slice of strs.
Owner
There was a problem hiding this comment.
ah, right. we could use intersperse from itertools, but it's not worth a new dependency. Maybe once it is stabilized in std 😄 (rust-lang/rust#79524, https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.intersperse)
Owner
|
Thank you for the update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows multiple
font_styles to be used, allowing, say, for a bold and italic text. Fixes #49All previous examples should work, but now you can also specify: