Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@menelaos
Copy link
Contributor

No description provided.

@sharkdp sharkdp merged commit dcbb1ec into sharkdp:master Nov 20, 2019
@sharkdp
Copy link
Owner

sharkdp commented Nov 20, 2019

Thank you very much!

@menelaos menelaos deleted the solarized branch November 25, 2019 19:15
@hferreiro
Copy link

@menelaos I have been using https://github.com/seebi/dircolors-solarized and noticed that the colors are a bit different. Didn't you use that as a source?

@menelaos
Copy link
Contributor Author

@hferreiro Good point, I used the standard values from dircolors in coreutils. They are indeed slightly different from the link above but I feel they are more consistent and easier on the eye. Have you tried to use them for a few days? Let me know what you think :-)

@hferreiro
Copy link

My first impression is the opposite, though I guess that's really subjective. My main issue is that directories seems to be bold and well-known extensions (e.g. .md, .py, .cc, .h) aren't highlighted. You can compare them here (the second one is from your theme):
Screenshot from 2020-04-25 00-32-25
seebi

@menelaos
Copy link
Contributor Author

Yes, you are right, it is a matter of preference in the end. I also used seebi/dircolors-solarized before so I feel where you are coming from.

Ultimately, I decided to follow coreutils and use the standard dircolors color scheme as it is more widely established. As I've already mentioned, I have since come to prefer it. Given that dircolors-solarized was never merged into the official solarized repo, I don't think it can be considered "official".

To address at least your second issue a little bit: The solarized page recommends base00 (light theme) and base0 (dark theme) for "primary content". I would argue that on the command line, almost all text files, whether it be source files or your grocery shopping list, are "primary content".
With seebi/dircolors-solarized you would often end up with lots of colors but very little "primary content".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants