Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Cache wireless device in NetworkManager backend#111

Merged
shazow merged 1 commit intomainfrom
cache-nm-device-4144469425020254271
Dec 16, 2025
Merged

Cache wireless device in NetworkManager backend#111
shazow merged 1 commit intomainfrom
cache-nm-device-4144469425020254271

Conversation

@google-labs-jules
Copy link
Contributor

Cached the wireless device in the Backend struct to avoid querying NetworkManager for devices on every call to getWirelessDevice.
Added a Device field to Backend struct and updated getWirelessDevice to use it.
Added a unit test TestGetWirelessDevice_Caching in wifi/networkmanager/networkmanager_test.go to verify the caching behavior using a mock NetworkManager.


PR created automatically by Jules for task 4144469425020254271 started by @shazow

- Added `Device` field to `Backend` struct to cache the wireless device.
- Updated `getWirelessDevice` to check the cache before querying NetworkManager.
- Added `networkmanager_test.go` with `TestGetWirelessDevice_Caching` to verify caching logic.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@shazow shazow marked this pull request as ready for review December 16, 2025 14:48
@shazow shazow merged commit b9e0172 into main Dec 16, 2025
2 checks passed
@shazow shazow deleted the cache-nm-device-4144469425020254271 branch December 16, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant