Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: HITL doesnt work of Python SDK #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenfengwang merged 1 commit into from
May 9, 2024
Merged

fix: HITL doesnt work of Python SDK #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 14 additions & 2 deletions sdk/python/npiai/core/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,20 @@ def hitl(self, handler: hitl.HITLHandler):
self.hitl_handler = handler

def __call_human(self, resp: api_pb2.Response) -> api_pb2.Request:
self.hitl_handler.handle(hitl.convert_to_hitl_request(resp.action_response))
return api_pb2.Request() # bypass
human_resp = self.hitl_handler.handle(hitl.convert_to_hitl_request(resp.action_response))
if human_resp is hitl.ACTION_APPROVED:
result = "approved"
else:
result = "denied"
return api_pb2.Request(
code=api_pb2.RequestCode.ACTION_RESULT,
request_id=str(uuid.uuid4()),
thread_id=resp.thread_id,
action_result_request=api_pb2.ActionResultRequest(
action_id=resp.action_response.action_id,
action_result=result,
)
)


class Agent:
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/npiai/core/hitl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class ActionResultCode(Enum):


class HITLRequest:
def __init__(self, code: ActionRequestCode, app_name: str, message: str):
def __init__(self, code: ActionRequestCode, message: str, app_name: str = 'Unknown'):
self.code = code
self.app_name = app_name
self.message = message
Expand Down Expand Up @@ -96,7 +96,7 @@ def handle(self, req: HITLRequest) -> HITLResponse:
if human_response is not None:
resp.message = human_response
return resp
return ACTION_APPROVED
return ACTION_DENIED

def type(self) -> api_pb2.ActionType:
return api_pb2.ActionType.CONSOLE
7 changes: 7 additions & 0 deletions sdk/python/tests/hitl/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
from npiai.app.google import Gmail
from npiai.core.hitl import ConsoleHITLHandler

if __name__ == '__main__':
gmail = Gmail()
gmail.hitl(handler=ConsoleHITLHandler())
print(gmail.chat("send an email to [email protected] saying hello"))