Fix issue reported by phpstan in CrossDomainMiddleware #2493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2493 +/- ##
=============================================
- Coverage 93.56% 93.55% -0.01%
Complexity 1756 1756
=============================================
Files 279 279
Lines 5963 5961 -2
=============================================
- Hits 5579 5577 -2
Misses 384 384 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a change in a recent version, PHPStan now reports an incorrect usage of
EmptyResponse::withHeaders.Things were working, probably due to internal checks accounting for headers set as
stringinstead ofstring[], but the type annotations were indicating the method was supposed to be used differently.This PR refactors that slightly to ensure it is used as intended.