fix: ShrinkWrapClassLoader finds ServiceProviders in WAR #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a branch of arquillian-container-weld with the tests and a patch. With this patch I try to intercept the loading of a service but I'm not so sure I'm using the right approach. |
dbf1476 to
1a13701
Compare
|
I'm surprised to see my PR re-opened. I've rebased it to the latest changes in main if it's something that can be helpful. |
It was never closed @DavideD intentionally :) It was mistakenly closed while changing branch name from |
bartoszmajsak
requested changes
Feb 11, 2022
api/src/main/java/org/jboss/shrinkwrap/api/classloader/ShrinkWrapClassLoader.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/jboss/shrinkwrap/api/classloader/ShrinkWrapClassLoader.java
Outdated
Show resolved
Hide resolved
1a13701 to
2fdb317
Compare
2fdb317 to
4d7f6f4
Compare
|
I've updated the branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can this work?
The ShrinkwrapClassloader look for a specified path and if it cannot find the ndoe than look for the asset in WEB-INF/classes/