This repository was archived by the owner on Jun 18, 2025. It is now read-only.
infinite? and fixes for generic arithmetic ops #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #448 +/- ##
==========================================
- Coverage 85.54% 85.51% -0.03%
==========================================
Files 97 97
Lines 13051 13071 +20
Branches 710 710
==========================================
+ Hits 11164 11178 +14
- Misses 1177 1183 +6
Partials 710 710
Continue to review full report at Codecov.
|
sritchie
commented
Jan 4, 2022
| (defmethod negative? :default [a] | ||
| (< a (v/zero-like a))) | ||
|
|
||
| (defgeneric infinite? 1 |
added 2 commits
January 4, 2022 05:38
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the CHANGELOG:
new
g/infinite?generic with implementations for all numeric types,complex numbers,
differentialinstances. Defaults tofalsefor all othertypes. (Also aliased into
sicmutils.env/infinite?).The infix, TeX and JavaScript renderers (
->infix,->TeXand->JavaScript) all properly render##Infand##-Inf. Infix uses theUnicode symbol ∞, while
->TeXuses the LaTeX command\infty.Javascript's
Infinitystands in for##Infin generated JS code.g/+,g/-,g//now short circuit if there is a NUMERIC zero on eitherside. This was causing bugs in cases where we allow, say, a scalar to be
added to a quaternion, and auto-convert the scalar right there (so it adds
only to the real part). OR in cases, like in the matrix PR, where we convert
the scalar in addition to
<scalar>*I*.sicmutils.matrixtests that were not welltyped.
The default
exptimplementation is now available as a function to calldirectly (
sicmutils.generic/default-expt) without going through thedispatch system.