This repository was archived by the owner on Jun 18, 2025. It is now read-only.
Add M->Euler to sicmutils.mechanics.rotation #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #491 +/- ##
==========================================
- Coverage 86.42% 86.37% -0.05%
==========================================
Files 100 100
Lines 14414 14441 +27
Branches 747 750 +3
==========================================
+ Hits 12457 12474 +17
- Misses 1210 1217 +7
- Partials 747 750 +3
Continue to review full report at Codecov.
|
04c4755 to
be9ff5d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sicmutils.mechanics.rotation/M->Euler, for converting from arotation matrix to a triple of Euler angles. Now we can successfully round
trip.