This repository was archived by the owner on Jun 18, 2025. It is now read-only.
Taylor series upgrades + extra tidying #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #514 +/- ##
==========================================
+ Coverage 86.49% 86.54% +0.04%
==========================================
Files 105 105
Lines 15320 15345 +25
Branches 781 776 -5
==========================================
+ Hits 13251 13280 +29
- Misses 1288 1289 +1
+ Partials 781 776 -5
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taylor series upgrades + extra tidying #514:
Modifies
sicmutils.calculus.derivative/taylor-seriesto return a properPowerSeriesinstance, which the user can call with somedxto get backthe old behavior.
The new version can take any number of arguments in addition to
f.Supplying no arguments returns the expansion at 0; if you supply many
arguments (totally fine!), you'll need to wrap your
dxcomponents in avector before supplying them to the returned
PowerSeries.sicmutils.series/function->works the same way now, and functionsidentically, but with a different implementation. (previously it took a
single expansion point under a keyword argument
:x0.)The new
sicmutils.calculus.derivative/symbolic-taylor-seriesis a port ofTaylor-series-coefficientsfromscmutils. It has the same contract astaylor-series, except that the full expansion is performed symbolically,and the original arguments are substituted in after expansion and
simplification.
Other changes:
Installs
1as theone-likeandidentity-likereturn values forstructures and vectors. A true identity element would be an identity
element compatible with all entries of the structure; but as defined now,
1is a fine choice and matches thescmutilsimplementation.new
sicmutils.differential/map-coefficients, which makessimplifyslightly more efficient by filtering terms .
more efficient
sicmutils.expression/variables-in, maybe 30% faster forbig expressions; this makes a difference in the simplifier!
sicmutils.expression/substitutenow works for properLiteralinstances. Before it only worked for unwrapped literals.
matrix walks made slightly faster by caching a row or column before
traversal