This repository was archived by the owner on Jun 18, 2025. It is now read-only.
Slim down imports, move examples => tests #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 21, 2023 16:08
Codecov ReportBase: 86.61% // Head: 86.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
==========================================
- Coverage 86.61% 86.48% -0.13%
==========================================
Files 104 98 -6
Lines 15356 15246 -110
Branches 774 783 +9
==========================================
- Hits 13301 13186 -115
+ Misses 1281 1277 -4
- Partials 774 783 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
added 2 commits
January 21, 2023 21:24
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slim down imports, move examples => tests #532:
Removes the
potemkindependency by importing only what we need directlyinto
sicmutils.util.def. This makes sense since our versions add aforkcall so that they work for ClojureScript as well.
Moves all
examplesinto the tests so that we don't ship them with thelibrary. These will eventually be converted to Clerk notebooks.
Removes the
hiccupdependency.Upgrades
test.chuckand removes all:include-macros truecalls for thatlibrary. Only
same/ishrequires them now!Capitalizes the "Script" in ClojureScript everywhere it appears.