Fix errors creating SigMFFile objects that do not have datatype set #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cddc7bc to
ee19c72
Compare
Teque5
approved these changes
Sep 28, 2021
Collaborator
Teque5
left a comment
There was a problem hiding this comment.
Yea looks good. I would attempt to see if this passes tests, but tests are broken for other reasons right now.
This prevents users from setting a datafile, which queries information that requires the datatype meta field to be set. It also generates a more useful exception when the dtype parser is run with None input.
ee19c72 to
ce873bc
Compare
Member
Author
|
@Teque5 i rebased this with the fixes you made; how are you running the SigMF test code? It would be good to add a test that catches this error. Nevermind, |
Member
Author
|
Test pass, approval. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents users from setting a datafile, which queries information that requires the datatype meta field to be set. It also generates a more useful exception when the dtype parser is run with None input.
Closes #178
@Teque5 I solved this in a slightly different way than described in #178 because that prevents constructing a plain
SigMFFile()object, which is reasonable and people might be doing this already. This only changes behavior that currently causes an obscure error.