tooling improvements for NCDs and captures access #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds a few new functions to better support non-compliant datasets and more effectively read from files. the new captures segment file reading function will work on compliant or noncompliant datasets and the existing read_samples() will present a warning for noncompliant datasets as it can potentially return invalid data. QA coverage for new functions is included.
Member
Author
|
Also, here is a visual I made to keep myself straight on the new QA datasets |
Contributor
|
This one definitely needs @Teque5's eyes as a reviewer. @Teque5, any chance you can get to this before disappearing for the holidays? 😄 @jacobagilbert - the image you made and posted 👆🏼👆🏼 is really good. Let's get that added to the Wiki (probably under a new page about QA?) so it doesn't get lost 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a few new functions to better support non-compliant datasets
and more effectively read from files. the new captures segment file
reading function will work on compliant or noncompliant datasets and the
existing read_samples() will present a warning for noncompliant datasets
as it can potentially return invalid data. QA coverage for new functions
is included.
Other notes:
SigMFAccessErrorwhich can be thrown when accessing missing but expected metadata fields, or invalid captures/sample elements. TODO: get rid of inlineasserts used for this..Closes #205