Change embedded version naming on proto types #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...V0_0_2 -> ...V002 See naming: https://protobuf.dev/programming-guides/style/#identifier We were initially using this to avoid collisions, but those are academic/theoretical and we can work around them. Additionally we now can identify collisions at the proto spec level rather than at generation time. Signed-off-by: Appu Goundan <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #329 +/- ##
=======================================
Coverage 38.05% 38.05%
=======================================
Files 41 41
Lines 2959 2959
=======================================
Hits 1126 1126
Misses 1728 1728
Partials 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...V0_0_2 -> ...V002
See naming: https://protobuf.dev/programming-guides/style/#identifier
We were initially using this to avoid collisions, but those are theoretical and we can work around them. Additionally we now can identify collisions at the proto spec level rather than at generation time.
Summary
Clients will once again need to regenerate type code. @jku we probably also want to disable pydantic here in a followup?
Release Note
Documentation