Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update doc for extra-openai-models.yaml, include mandatory model_name #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2025
Merged

Update doc for extra-openai-models.yaml, include mandatory model_name #957

merged 1 commit into from
May 4, 2025
+3 −0

Conversation

rahimnathwani
Copy link
Contributor

@rahimnathwani rahimnathwani commented Apr 25, 2025 •
edited
Loading

The documentation doesn't work as-is: if you create a file without model_name, then no calls to llm will work.

@simonw
Copy link
Owner

simonw commented May 4, 2025

Thanks for catching this.

@simonw simonw merged commit 07ccfbc into simonw:main May 4, 2025
1 check passed
This was referenced May 4, 2025
Merged
Closed
simonw added a commit that referenced this pull request May 5, 2025
@simonw
Release 0.25
8df8393 
Refs #876, #887, #903, #904, #907, #908, #916, #918, #925, #929, #932, #933, #941, #945, #949, #950, #957, #965, #968, #969, #972, #973, #974, #975, #976
@mmacy mmacy mentioned this pull request May 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rahimnathwani @simonw