-
Notifications
You must be signed in to change notification settings - Fork 4
Migrate to Qt6 #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Migrate to Qt6 #140
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b11c3b3
refactor: upgrade to Qt6 and resolve breaking changes
samuelshng 321633a
refactor: replace Zipper dependency with miniz which simplifies libra…
samuelshng e0a0341
build: update CMake for Windows deployment
samuelshng f8d3a53
Squashed commit of the following:
samuelshng 49955b8
ci: only build windows binaries on main or dev branches
samuelshng e8630c9
docs: add latest build instructions
samuelshng a938a44
refactor: resolve a few Qt6 deprecation warnings
samuelshng 18f7e41
feat: update plugins
samuelshng 84d34d1
refactor: change QCheckBox::stateChanged to QCheckBox::checkStateChan…
samuelshng 0ed6e67
ci: change GitHub Action dependencies to qt6
samuelshng 41a3849
fix: CMake macro `qt_standard_project_setup()` is only supported for …
samuelshng ca7dc09
fix: renaming `QCheckBox::stateChanged` to `QCheckBox::checkStateChan…
samuelshng b745eb6
fix: hidpi mode was removed from settings.cc but not from visual.xml …
samuelshng 6a857d9
docs: fix 22.04 and 24.04 apt dependency typo
samuelshng d31f146
ci: update ubuntu GitHub Action with correct Qt6 dependencies and exp…
samuelshng 8197b3c
fix(ci): remove g++ from macOS GitHub Action because it doesn't play …
samuelshng 5c6742a
ci: upgrade install-boost action in build-windows action
samuelshng 9770a35
style: add line ending for source & header files
samuelshng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| name: Build and Package on Windows | ||
|
|
||
| on: | ||
| push: | ||
| branches: ["master"] | ||
| paths: | ||
| - "**/*.py" | ||
| - '**/*.h' | ||
| - '**/*.cc' | ||
| - '**/*.cmake' | ||
| - '**/CMakeLists.txt' | ||
| - 'libs/**' | ||
| - '.github/workflows/macos.yml' | ||
| pull_request: | ||
| branches: ["master"] | ||
| paths: | ||
| - "**/*.py" | ||
| - '**/*.h' | ||
| - '**/*.cc' | ||
| - '**/*.cmake' | ||
| - '**/CMakeLists.txt' | ||
| - 'libs/**' | ||
| - '.github/workflows/macos.yml' | ||
|
|
||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: windows-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| submodules: 'recursive' | ||
|
|
||
| - name: Set up MSVC | ||
| uses: ilammy/msvc-dev-cmd@v1 | ||
| with: | ||
| toolset: "14.29" | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.12' | ||
| cache: 'pip' # caching pip dependencies | ||
|
|
||
| - name: Install CMake | ||
| uses: lukka/[email protected] | ||
|
|
||
| # Go to this website if the Qt version config needs to be updated: | ||
| # https://ddalcino.github.io/aqt-list-server/ | ||
| - name: Install Qt | ||
| uses: jurplel/install-qt-action@v3 | ||
| id: install-qt | ||
| with: | ||
| aqtversion: '==3.1.*' | ||
| version: '6.7.0' | ||
| host: 'windows' | ||
| target: 'desktop' | ||
| arch: 'win64_msvc2019_64' | ||
| modules: 'qtcharts' | ||
|
|
||
| - name: Install boost | ||
| uses: MarkusJx/[email protected] | ||
| id: install-boost | ||
| with: | ||
| boost_version: 1.84.0 | ||
| platform_version: 2019 | ||
| toolset: msvc | ||
| if: runner.os == 'Windows' | ||
|
|
||
| - name: Create build directory | ||
| run: mkdir build | ||
|
|
||
| - name: Configure | ||
| working-directory: ./build | ||
| run: cmake .. -G "Ninja" -DCMAKE_BUILD_TYPE="Release" -DCMAKE_INSTALL_PREFIX="${{ github.workspace }}/install" -DBOOST_INCLUDE_DIR="${{steps.install-boost.outputs.BOOST_ROOT}}/include" | ||
| env: | ||
| BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }} | ||
|
|
||
| - name: Build | ||
| working-directory: ./build | ||
| run: ninja -f build.ninja | ||
|
|
||
| - name: Install | ||
| working-directory: ./build | ||
| run: ninja -f build.ninja install | ||
|
|
||
| - name: Archive Artifacts | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: siqad-package | ||
| # if using matrix build in the future | ||
| # name: siqad-package-${{ matrix.runs-on }} | ||
| path: ${{ github.workspace }}/install/** | ||
| retention-days: 5 # Optional: adjust as necessary | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Ensure that the Linux installation instructions are updated to clearly reflect the need for compiling from source with Qt6 support and revise related documentation links if needed.