refactor: Transliterate component #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Transliterate component to improve type safety and code clarity. Key changes include replacing the lookup type with Record<string, string>, removing the explicit constructor and method binding by leveraging arrow functions, and caching the transliterated value in both the copyText and render methods.
sjinks
commented
May 12, 2025
| constructor(props: ITransliterateProps) { | ||
| super(props); | ||
|
|
||
| this.copyText = this.copyText.bind(this); |
There was a problem hiding this comment.
copyText is an arrow function; bind is unnecessary.
sjinks
commented
May 12, 2025
| navigator.userAgent.indexOf('Mac OS X') !== -1 ? '⌘' : 'Ctrl'; | ||
|
|
||
| return ( | ||
| <> |
There was a problem hiding this comment.
Fragment is unnecessary if there is only one child.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.