FIX - Improving the error message raised when the TableReport is called on a lazy polars dataframe #1767
Conversation
…o TableReport and added a line to the changelog
…o TableReport and added a line to the changelog
Updated pull request reference for improved error message in TableReport.
|
Hi @fatiben2002, is there a reason why you opened this PR rather than continuing with #1732? It's not a big deal, just making sure we keep the work in one place. |
Hi @rcap107, I was encountering some issues with my branch and my software so I couldn't push to the old request. Hope it's okay, also I joined the link of the last PR in the current PR description. Thank u ! |
|
Hi @fatiben2002, thanks a lot for the PR. I pushed a few formatting fixes just so you wouldn't have to bother with that. If you're curious, all I had to do was running I also moved the changelog entry from "Bugfixes" to "Changes". Other than that, the code looks good, and we can merge once the tests pass. |
_table_report.py, the extra function for raising an exception and added the latter directly in the classTableReport.test_table_report.pypl = pytest.importorskip("polars")test_table_report.pyfor the test functionP.S: There was an old comment about the same fix in the changelog by another user, I did not delete it. Let me know if I should :) or if I need any other changes. Sorry for the delay again!
Note: Due to some issue with the branch I had to create a new PR, here is the link to the last one.