Added type-specific error message to cross_validate function #1799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jeromedockes
left a comment
There was a problem hiding this comment.
Looks great! thank you @emassoulie and welcome to skrub :)
Co-authored-by: Jérôme Dockès <[email protected]>
rcap107
approved these changes
Dec 11, 2025
Member
rcap107
left a comment
There was a problem hiding this comment.
Looks good to me, thanks a lot @emassoulie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix Pull Request
Description
Fixes #1773, giving a more verbose error message when the cross_validate function receives an incorrect input.
How Has This Been Tested?
Running cross_validate with expected and unexpected types.
Steps to Reproduce (original bug)
Run skrub.cross_validate with a data_op type as input rather than a learner.
Additional Notes