[ENH] prophet adapter - safer handling of fit_kwargs
#5622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
yarnabrina
approved these changes
Dec 14, 2023
fkiraly
pushed a commit
that referenced
this pull request
Dec 24, 2023
Discussion #5197 Depends on #5622 which should be merged first. #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> This PR extracts the piece wise linear trend from the prophet algorithm. The algorithm is well suited to be used for trend forecasting in a pipeline and less useful alone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a minor change to code introduced in #5597 that prevents breakeage if
self.fit_kwargsare not available in a descendant of the_ProphetAdapter, such as in the piecewise linear trend forecaster, in #5592