Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ENH] SCINet forecaster #7400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fkiraly merged 12 commits into from
Dec 1, 2024
Merged

[ENH] SCINet forecaster #7400

fkiraly merged 12 commits into from
Dec 1, 2024

Conversation

@Sohaib-Ahmed21
Copy link
Contributor

@Sohaib-Ahmed21 Sohaib-Ahmed21 commented Nov 17, 2024 •
edited by geetu040
Loading

Reference Issues/PRs

Fixes #6831

What does this implement/fix? Explain your changes.

It adds time series forecasting model SCINet to sktime.

Does your contribution introduce a new dependency? If yes, which one?

No.

Did you add any tests for the change?

No

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the sktime root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • Optionally, for added estimators: I've added myself and possibly to the maintainers tag - do this if you want to become the owner or maintainer of an estimator you added.
    See here for further details on the algorithm maintainer role.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

@Sohaib-Ahmed21
Copy link
Contributor Author

Sohaib-Ahmed21 commented Nov 18, 2024

Kindly can some maintainer approve the workflows.

@fkiraly
Copy link
Collaborator

fkiraly commented Nov 18, 2024

I assume this is still work in progress?

@fkiraly fkiraly added implementing algorithms Implementing algorithms, estimators, objects native to sktime module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting enhancement Adding new functionality labels Nov 18, 2024
@Sohaib-Ahmed21
Copy link
Contributor Author

Sohaib-Ahmed21 commented Nov 19, 2024

I assume this is still work in progress?

Yes just minor things left.

@Sohaib-Ahmed21
Copy link
Contributor Author

Sohaib-Ahmed21 commented Nov 19, 2024

Kindly can some maintainer approve the workflows.

@Sohaib-Ahmed21 Sohaib-Ahmed21 marked this pull request as ready for review November 19, 2024 16:56
@Sohaib-Ahmed21
Copy link
Contributor Author

Sohaib-Ahmed21 commented Nov 19, 2024

The PR is ready for review. Someone please review this.

geetu040
geetu040 suggested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@geetu040 geetu040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

I have requested some minor changes.

@Sohaib-Ahmed21
Copy link
Contributor Author

Sohaib-Ahmed21 commented Nov 22, 2024

Thanks for the review @geetu040! I will address these soon except wrapping of network classes which needs discussion here.

@Sohaib-Ahmed21
Refactored SCINet implementation in sktime, improving docstrings, com…
b8b62c9 
…ments and code. In code: removed unnecessary params and improved test cases
@Sohaib-Ahmed21
Copy link
Contributor Author

Sohaib-Ahmed21 commented Nov 23, 2024

@geetu040 I have addressed the reviews except wrapping of network classes which needs discussion here. Kindly approve the workflows.

Sohaib-Ahmed21 and others added 2 commits November 28, 2024 02:03
@Sohaib-Ahmed21
Added wrappers on top of pytorch nn.Module's children classes in SCIN…
5e0bfdf 
…et forecaster to not expose the soft dependency i.e. torch on modular level explicitly.
@Sohaib-Ahmed21
Merge branch 'main' into scinet
0d805af
@Sohaib-Ahmed21
Copy link
Contributor Author

Sohaib-Ahmed21 commented Nov 28, 2024

@geetu040 @fkiraly This PR is ready for the review. Kindly check.

geetu040
geetu040 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@geetu040 geetu040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Please update the PR description, that goes with the merge commit.

@fkiraly fkiraly merged commit 7eeff35 into sktime:main Dec 1, 2024
65 checks passed
@fkiraly fkiraly changed the title [ENH] add SCINet forecaster [ENH] SCINet forecaster Dec 1, 2024
benHeid pushed a commit that referenced this pull request Feb 15, 2025
@Sohaib-Ahmed21 @benHeid
[ENH] SCINet forecaster (#7400)
abc6efc 
Fixes #6831, adds time series forecasting model SCINet to sktime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achieveordie achieveordie Awaiting requested review from achieveordie

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

@fkiraly fkiraly Awaiting requested review from fkiraly fkiraly is a code owner

@fnhirwa fnhirwa Awaiting requested review from fnhirwa

@pranavvp16 pranavvp16 Awaiting requested review from pranavvp16

@XinyuWuu XinyuWuu Awaiting requested review from XinyuWuu

@yarnabrina yarnabrina Awaiting requested review from yarnabrina yarnabrina is a code owner

1 more reviewer

@geetu040 geetu040 geetu040 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Adding new functionality implementing algorithms Implementing algorithms, estimators, objects native to sktime module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ENH] add SCINet forecaster

3 participants

@Sohaib-Ahmed21 @fkiraly @geetu040