Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ENH] only run test_load_fpp3_public when rdata is installed#8891

Merged
fkiraly merged 1 commit intosktime:mainfrom
noxthot:bug/8879-tests_miss_dependency
Oct 4, 2025
Merged

[ENH] only run test_load_fpp3_public when rdata is installed#8891
fkiraly merged 1 commit intosktime:mainfrom
noxthot:bug/8879-tests_miss_dependency

Conversation

@noxthot
Copy link
Contributor

@noxthot noxthot commented Oct 3, 2025

Reference Issues/PRs

Fixes #8879

What does this implement/fix? Explain your changes.

Skips test of test_load_fpp3_public when soft dependency rdata is not available.

Does your contribution introduce a new dependency? If yes, which one?

no

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the sktime root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • Optionally, for added estimators: I've added myself and possibly to the maintainers tag - do this if you want to become the owner or maintainer of an estimator you added.
    See here for further details on the algorithm maintainer role.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

@yarnabrina yarnabrina added the module:datasets&loaders data sets and data loaders label Oct 3, 2025
@fkiraly fkiraly changed the title [MNT]: only run test_load_fpp3_public when rdata is installed [ENH] only run test_load_fpp3_public when rdata is installed Oct 3, 2025
@fkiraly fkiraly added the enhancement Adding new functionality label Oct 3, 2025
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fkiraly fkiraly changed the title [ENH] only run test_load_fpp3_public when rdata is installed [ENH] only run test_load_fpp3_public when rdata is installed Oct 3, 2025
@fkiraly
Copy link
Collaborator

fkiraly commented Oct 4, 2025

quick merge due to failure on main

@fkiraly fkiraly merged commit 5250804 into sktime:main Oct 4, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adding new functionality module:datasets&loaders data sets and data loaders

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Running tests fails due to missing requests dependency

3 participants