This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Work towards having custom actions for objects #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: * Makes a couple of trivial one-byte size optimizations. * Adds space in our item-table for a pointer to custom actions. In the future we'll have a per-object set of verbs, such as "READ" which only works for "BOOK". Right now I've just declared space for it as I work on the implementation. Confirmed the game still plays correctly with this change, just for paranoia's sake.
This commit adds a simple table for per-item actions, and moves the "READ" function into the entry for the book. We don't yet invoke the handler, but we do successfully look for a) the object, and b) the custom verbs for it. If they're not present we continue - otherwise we show a temporary debugging message to confirm an action was found.
This commit allows us to run "READ BOOK", and "MOVE RUG", without also allowing "READ TORCH", or "MOVE BOOK"! Success. Though it seems like I need to work on the text a little, since examining the book now will also read it. I could say "You can't use the telephone without having read the book", but that feels a bit pointless. I'll just change the examination to provide a hint to _read_ in the future.
In the past we removed " THE " and " ON " from input, to avoid issues with "TAKE THE RUG" and "TURN ON TORCH". Now we've updated so that our routine to fetch the "second" word always takes the *last* word: * TAKE THE TORCH -> TORCH * Not "THE". This means we can have an abitrary prefix for custom actions, and that means we don't need to care about the extra ON/THE. Also I've implemented OPEN/CLOSE trapdoor and TURN ON/OFF/LIGHT the torch. These "just" do a toggle, but that's okay for now. We only have one custom use function left, which refers to the generator. We should probably change that to "start".
Since this was only necessary to start the generator I've added an explicit "START GENERATOR" handler. This cuts down on our code, and also simplifies things. I've hidden the CLEAR command from the output of help. The game plays successfull and both exit conditions work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this pull-request is complete we'll have support for custom / per-item actions.
Currently we have a generic "USE FOO" option, and we have declared synonyms such as "READ" for "USE". This means you can enter:
Those things work due to the synonym, but they're clearly crazy. So what we want to do is store per-item actions specially so that "READ BOOK" works, but the READ verb only works on the book, not other items.
We already have per-object "TAKE", "DROP", "EXAMINE", functions which probably get simplified, but that would be a bonus.
Implementation will be broken down into logical steps, and I will ensure the game is playable at each commit.
Once complete this closes #23.