Keep list numbers continuous when separated by certain elements#3086
Merged
jhchen merged 1 commit intoslab:developfrom Jul 5, 2020
Merged
Keep list numbers continuous when separated by certain elements#3086jhchen merged 1 commit intoslab:developfrom
jhchen merged 1 commit intoslab:developfrom
Conversation
Member
|
Merged in 586e49a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, blocks (except p and headings) reset inner lists' numbers, which is caused by
counter-reset. The intention was to usecounter-resetto reset number values to 0 but there's a side effect that can create a new counter.This change uses
counter-setinstead to avoid the side effect.Test plan:
In supported browsers, make sure the list number shows correctly as the following screenshot:
In other browsers, the numbers should not change.