Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@zdomke
Copy link
Collaborator

@zdomke zdomke commented Sep 30, 2024

This PR adds the ability to import and convert StripTool files (.stp) to Trace files (.trc). This works the same as importing and converting the Java-based Archive Viewer save files. It should be very straight forward.

Minor Changes:

  • When importing files, the file conversion is handled by the converter object rather than needing to be called separately. This let's the converter handle converting xml data vs stp data. Just faster/easier.
  • Removed context menu from the plot. Right clicking is now a panning tool.

Bug Fix:
Fixed a bug when importing Plot Configuration options. Functions being called expected bools, but were given Truey/Falsey values. Just converted the values to bools to fix this issue.

Docs:
Added importing StripTool to documentation. Also included example Archive Viewer and StripTool save files for users to try importing those. Cause why not ¯\_(ツ)_/¯ ??

@zdomke zdomke marked this pull request as ready for review September 30, 2024 18:35
Copy link
Collaborator

@YektaY YektaY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@YektaY YektaY merged commit 2c5f762 into slaclab:main Sep 30, 2024
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants