Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH: Add Axis Settings Modal #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 22, 2025
Merged

ENH: Add Axis Settings Modal #137

merged 7 commits into from
Apr 22, 2025

Conversation

@zdomke
Copy link
Collaborator

@zdomke zdomke commented Apr 16, 2025 •
edited
Loading

Add a modal for controlling the settings of an axis.

The modal class, AxisSettingsModal, takes in 3 arguments:

  • parent: QWidget
    • This is the parent object of the modal. Should be whatever button opens the modal
  • plot: PyDMArchiverTimePlot
    • This is the main plot of Trace
    • This is only used for redrawing the plot when the orientation changes. This should probably be done in PyDM instead of here
  • axis: BasePlotAxisItem
    • The axis item that is controlled by the modal

The modal contains settings for:

  • Changing the axis' orientation (left/right side)
  • Enabling/disabling log mode for the axis
  • Enabling/disabling gridlines on the axis
    • The opacity relies on the opacity slider from the PlotSettingsModal. This is done to keep the gridline opacity consistent across the plot

@zdomke zdomke self-assigned this Apr 17, 2025
@zdomke zdomke added the enhancement New feature or request label Apr 17, 2025
@zdomke zdomke added this to the Trace 1.5 milestone Apr 17, 2025
@zdomke zdomke linked an issue Apr 17, 2025 that may be closed by this pull request
[FEATURE] - Redesign Trace #135
Closed
@zdomke zdomke requested a review from a team April 17, 2025 18:06
@zdomke zdomke marked this pull request as ready for review April 17, 2025 18:06
@zdomke zdomke mentioned this pull request Apr 21, 2025
Merged
ngAlexander9
ngAlexander9 approved these changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@ngAlexander9 ngAlexander9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay!

@zdomke
Copy link
Collaborator Author

zdomke commented Apr 21, 2025

Just realized that I didn't include a way of changing the axis' name. This should be included in this settings modal, similar to the name in #138.

@zdomke zdomke force-pushed the zdomke/axis_settings branch from e4568fc to 56df06a Compare April 22, 2025 16:55
@zdomke zdomke requested a review from YektaY April 22, 2025 17:25
@zdomke
Copy link
Collaborator Author

zdomke commented Apr 22, 2025

Just realized that I didn't include a way of changing the axis' name. This should be included in this settings modal, similar to the name in #138.

Holding off on this change for now. I talked with @shilorigins and we might make the axis labels in #139 editable instead.

YektaY
YektaY approved these changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@YektaY YektaY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me--you may want to add docstrings to some of the new methods. but that can also be done in a later pass

@zdomke zdomke merged commit f28dc2a into ui_redesign Apr 22, 2025
1 check passed
@shilorigins shilorigins deleted the zdomke/axis_settings branch April 22, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YektaY YektaY YektaY approved these changes

@ngAlexander9 ngAlexander9 ngAlexander9 approved these changes

Assignees

@zdomke zdomke

Labels

enhancement New feature or request

Projects

None yet

Milestone

Trace 1.5

Development

Successfully merging this pull request may close these issues.

[FEATURE] - Redesign Trace

4 participants

@zdomke @YektaY @ngAlexander9