Thanks to visit codestin.com
Credit goes to github.com

Skip to content

GUI: enable drag-and-drop for moving curve items between axes #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2025
Merged

GUI: enable drag-and-drop for moving curve items between axes #157

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
312eea5
GUI: enable drag-and-drop for moving curve items between axes
shilorigins May 28, 2025
8e9adfc
GUI: style drag-and-drop for ControlPanel curves
shilorigins May 29, 2025
56ef21a
GUI: smooth jitteriness when dragging curve over placeholder
shilorigins May 29, 2025
f0959de
GUI: expand AxisItem when dragging curve over it
shilorigins May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 67 additions & 3 deletions trace/widgets/control_panel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import qtawesome as qta
from qtpy import QtCore, QtWidgets
from qtpy.QtGui import QCloseEvent
from qtpy import QtGui, QtCore, QtWidgets

from config import logger
from widgets import AxisSettingsModal, CurveSettingsModal
Expand Down Expand Up @@ -112,7 +111,7 @@ def add_curve(self, pv: str = None):
last_axis = self.axis_list.itemAt(self.axis_list.count() - 2).widget()
last_axis.add_curve(pv)

def closeEvent(self, a0: QCloseEvent):
def closeEvent(self, a0: QtGui.QCloseEvent):
for axis_item in range(self.axis_list.count()):
axis_item.close()
super().closeEvent(a0)
Expand All @@ -125,6 +124,7 @@ def __init__(self, plot_axis_item):
super().__init__()
self.source = plot_axis_item
self.setLayout(QtWidgets.QVBoxLayout())
self.setAcceptDrops(True)

self.header_layout = QtWidgets.QHBoxLayout()
self.layout().addLayout(self.header_layout)
Expand Down Expand Up @@ -182,6 +182,10 @@ def __init__(self, plot_axis_item):
self.active_toggle.stateChanged.connect(self.set_active)
self.header_layout.addWidget(self.active_toggle)

self.placeholder = QtWidgets.QWidget(self)
self.placeholder.hide()
self.placeholder.setStyleSheet("background-color: lightgrey;")

@property
def plot(self):
return self.parent().parent().parent().parent().plot
Expand Down Expand Up @@ -264,6 +268,44 @@ def show_settings_modal(self):
self.settings_modal = AxisSettingsModal(self.settings_button, self.plot, self.source)
self.settings_modal.show()

def dragEnterEvent(self, event: QtGui.QDragEnterEvent):
if event.possibleActions() & QtCore.Qt.MoveAction:
event.acceptProposedAction()
self.placeholder.setMinimumSize(event.source().size())
self.placeholder.show()
if not self._expanded:
self.toggle_expand()

def dragMoveEvent(self, event: QtGui.QDragMoveEvent):
item = self.childAt(event.position().toPoint())
if item != self.placeholder:
self.layout().removeWidget(self.placeholder)
index = self.layout().indexOf(item) + 1 # drop below target row
index = max(1, index) # don't drop above axis detail row
self.layout().insertWidget(index, self.placeholder)

def dragLeaveEvent(self, event: QtGui.QDragLeaveEvent):
event.accept()
self.layout().removeWidget(self.placeholder)
self.placeholder.hide()

def dropEvent(self, event: QtGui.QDropEvent):
event.accept()
curve_item = event.source()
curve_item.curve_deleted.disconnect()
curve_item.curve_deleted.connect(self.curves_list_changed.emit)
curve_item.active_toggle.setCheckState(self.active_toggle.checkState())
self.plot.plotItem.unlinkDataFromAxis(curve_item.source)
self.plot.plotItem.linkDataToAxis(curve_item.source, self.source.name)
curve_item.source.y_axis_name = self.source.name

self.layout().removeWidget(curve_item) # in case we're reordering within an AxisItem
self.layout().replaceWidget(self.placeholder, curve_item)
self.placeholder.hide()
if not self._expanded:
self.toggle_expand()
self.curves_list_changed.emit()

def close(self) -> bool:
while self.layout().count() > 1:
self.layout().itemAt(1).widget().close()
Expand All @@ -276,6 +318,11 @@ def close(self) -> bool:
return super().close()


class DragHandle(QtWidgets.QPushButton):
def mousePressEvent(self, event: QtGui.QMouseEvent):
event.ignore()


class CurveItem(QtWidgets.QWidget):
curve_deleted = QtCore.Signal()

Expand All @@ -284,6 +331,13 @@ def __init__(self, plot_curve_item):
self.source = plot_curve_item
self.setLayout(QtWidgets.QHBoxLayout())

self.handle = DragHandle()
self.handle.setFlat(True)
self.handle.setIcon(qta.icon("ph.dots-six-vertical", scale_factor=1.5))
self.handle.setStyleSheet("border: None;")
self.handle.setCursor(QtGui.QCursor(QtCore.Qt.OpenHandCursor))
self.layout().addWidget(self.handle)

self.active_toggle = QtWidgets.QCheckBox("Active")
self.active_toggle.setCheckState(QtCore.Qt.Checked if self.source.isVisible() else QtCore.Qt.Unchecked)
self.active_toggle.stateChanged.connect(self.set_active)
Expand Down Expand Up @@ -351,6 +405,16 @@ def set_curve_pv(self, pv: str = None):
pv = self.sender().text()
self.source.address = pv

def mousePressEvent(self, event: QtGui.QMouseEvent):
if event.button() == QtCore.Qt.LeftButton and self.handle.geometry().contains(event.position().toPoint()):
self.hide() # hide actual widget so it doesn't conflict with pixmap on cursor
drag = QtGui.QDrag(self)
drag.setMimeData(QtCore.QMimeData())
drag.setPixmap(self.grab())
drag.setHotSpot(self.handle.geometry().center())
drag.exec()
self.show() # show curve after drag, even if it ended outside of an axis

def close(self) -> bool:
self.plot.removeCurve(self.source)
self.setParent(None)
Expand Down