Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Live + archive data moved to curve settings #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 26, 2025
Merged

Live + archive data moved to curve settings #186

merged 5 commits into from
Aug 26, 2025

Conversation

@michaellans
Copy link
Collaborator

@michaellans michaellans commented Aug 21, 2025 •
edited
Loading

  • Moved live and archive data option check boxes from control panel to curve settings modal
    • Live and archive connection status indicators are still on the control panel, moved them to be inline with label, settings and delete buttons
  • Also added legend on by default to this PR
Screenshot 2025-08-22 at 15 36 59 Screenshot 2025-08-22 at 15 37 10

@YektaY YektaY linked an issue Aug 21, 2025 that may be closed by this pull request
[FEATURE] - Live + archive data moved to curve settings #169
Closed
@michaellans michaellans marked this pull request as ready for review August 22, 2025 22:55
@zdomke zdomke requested a review from a team August 25, 2025 16:29
@zdomke zdomke changed the base branch from ui_redesign to main August 25, 2025 16:31
zdomke
zdomke approved these changes Aug 25, 2025
View reviewed changes
Copy link
Collaborator

@zdomke zdomke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!!
I found one small merge conflict that I fixed up in eadc53a

@zdomke
Copy link
Collaborator

zdomke commented Aug 25, 2025

Closes #168

@zdomke zdomke linked an issue Aug 25, 2025 that may be closed by this pull request
[FEATURE] - Legend on by default #168
Closed
@zdomke zdomke merged commit f7d44ce into slaclab:main Aug 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zdomke zdomke zdomke approved these changes

Assignees

@michaellans michaellans

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] - Live + archive data moved to curve settings [FEATURE] - Legend on by default

2 participants

@michaellans @zdomke