Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@zdomke
Copy link
Collaborator

@zdomke zdomke commented Aug 2, 2024

Restructure ItemDelegates to make an abstract class to manage the editor_list. Added functionality to reset the editor_list on model reset.

@zdomke zdomke changed the title Restructure Item Delegates FIX: Restructure Item Delegates Aug 6, 2024
Copy link
Collaborator

@YektaY YektaY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Would just request that the doc stings have the parameters and returns added to them.

@zdomke
Copy link
Collaborator Author

zdomke commented Aug 9, 2024

Additional changes:

  1. Added abstractmethods to EditorDelegate
  2. Removed the unused delegates SliderDelegate and CheckboxDelegate
    a. This also included removing the now unused widget CenterCheckbox (deprecated in Archive Viewer Update #16)

@YektaY YektaY merged commit df0e2b0 into slaclab:main Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants