Fix XGBoostFeatureSelector #156
Conversation
| ) -> None: | ||
| """Validates `XGBoostFeatureSelector` instanation passes with valid inputs for classification.""" | ||
| X, y = clf_x_y_data | ||
| # TODO(amir): callbacks=True has not been tested yet. The look of `self._cv()` would change |
There was a problem hiding this comment.
This is still a TODO
|
|
||
| def plot_frequency( | ||
| self, | ||
| *, |
There was a problem hiding this comment.
We need to make * required for all named args in the class methods. We did have them required in the upstream viz functions; not for the downstream ones tho.
Codecov ReportBase: 67.50% // Head: 80.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
===========================================
+ Coverage 67.50% 80.43% +12.93%
===========================================
Files 22 22
Lines 1997 1963 -34
Branches 302 263 -39
===========================================
+ Hits 1348 1579 +231
+ Misses 602 329 -273
- Partials 47 55 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Description
XGBoostFeatureSelector+ added unit-tests.Selectionnotebook example with classification and regression.TODO
callbacks=Trueflag will fail and the logic should be changed.Resolves: #issue-number-here
Pull Request Checklist