Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@amirhessam88
Copy link
Member

@amirhessam88 amirhessam88 commented Nov 13, 2022

Description

  • Refactored XGBoostBayesianOptimizer + unit-tests.
  • Updated the notebook example, respectively.
  • Cleaned some docs and README.md.

Resolves: #issue-number-here

Pull Request Checklist

  • Added tests for added or changed code.
  • Added documentation for changed code.

@amirhessam88 amirhessam88 self-assigned this Nov 13, 2022
@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Base: 80.58% // Head: 88.04% // Increases project coverage by +7.46% 🎉

Coverage data is based on head (9d678d0) compared to base (b55cd60).
Patch coverage: 49.77% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   80.58%   88.04%   +7.46%     
==========================================
  Files          21       22       +1     
  Lines        1931     1890      -41     
  Branches      244      222      -22     
==========================================
+ Hits         1556     1664     +108     
+ Misses        321      172     -149     
  Partials       54       54              
Flag Coverage Δ
unittests 88.04% <49.77%> (+7.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/slickml/optimization/_hyperopt.py 0.00% <0.00%> (ø)
src/slickml/base/_estimator.py 98.64% <100.00%> (ø)
src/slickml/optimization/_bayesianopt.py 100.00% <100.00%> (ø)
src/slickml/selection/_xgboost.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amirhessam88 amirhessam88 merged commit df29d0c into master Nov 13, 2022
@amirhessam88 amirhessam88 deleted the amir/bayesian branch November 13, 2022 19:20
@amirhessam88 amirhessam88 added the enhancement New feature or request label Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants