Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Roll-out type checking with mypy #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amirhessam88 merged 1 commit into from
Nov 28, 2022
Merged

Roll-out type checking with mypy #171

amirhessam88 merged 1 commit into from
Nov 28, 2022

Conversation

@amirhessam88
Copy link
Member

@amirhessam88 amirhessam88 commented Nov 28, 2022 •
edited
Loading

Description

  • Turned on type-checking in mypy.ini.
  • Fixed all type-checking errors across library.
  • Down the road we can turn on strict mode. Currently, 90% of the errors in strict mode will be related to tests/ which is good and easy to enable down the road.

Resolves: #issue-number-here

Pull Request Checklist

  • Added tests for added or changed code.
  • Added documentation for changed code.

@amirhessam88 amirhessam88 self-assigned this Nov 28, 2022
@amirhessam88 amirhessam88 added the enhancement New feature or request label Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 93.73% // Head: 93.39% // Decreases project coverage by -0.34% ⚠️

Coverage data is based on head (fc4539f) compared to base (1f91289).
Patch coverage: 84.74% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   93.73%   93.39%   -0.35%     
==========================================
  Files          22       22              
  Lines        1869     1876       +7     
  Branches      202      209       +7     
==========================================
  Hits         1752     1752              
  Misses         63       63              
- Partials       54       61       +7
Flag Coverage Δ
unittests 93.39% <84.74%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/slickml/utils/_validation.py 100.00% <ø> (ø)
src/slickml/visualization/_metrics.py 82.14% <0.00%> (ø)
src/slickml/classification/_xgboostcv.py 98.33% <75.00%> (-1.67%) ⬇️
src/slickml/regression/_xgboostcv.py 98.27% <75.00%> (-1.73%) ⬇️
src/slickml/selection/_xgboost.py 97.19% <82.75%> (-2.81%) ⬇️
src/slickml/base/_estimator.py 98.64% <100.00%> (ø)
src/slickml/classification/_xgboost.py 100.00% <100.00%> (ø)
src/slickml/metrics/_classification.py 99.25% <100.00%> (ø)
src/slickml/metrics/_regression.py 98.97% <100.00%> (ø)
src/slickml/optimization/_bayesianopt.py 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amirhessam88 amirhessam88 merged commit 664df08 into master Nov 28, 2022
@amirhessam88 amirhessam88 deleted the amir/mypy branch November 28, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@amirhessam88 amirhessam88

Labels

enhancement New feature or request

Projects

SlickML Task Board
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amirhessam88