Thanks to visit codestin.com
Credit goes to github.com

Skip to content

process_images.sh: allow skipping workspace validation#61

Merged
markusweigelt merged 3 commits intomainfrom
skip-validation
Jul 3, 2023
Merged

process_images.sh: allow skipping workspace validation#61
markusweigelt merged 3 commits intomainfrom
skip-validation

Conversation

@bertsky
Copy link
Member

@bertsky bertsky commented Jun 29, 2023

needed as a stopgap measure; currently needed because we must wait for adoption of OCR-D/core#1066

@markusweigelt
Copy link
Collaborator

Don't you think it's a better way to customize the global function post_validate_workdir in the file ocrd_lib.sh than in any implementation file or do you see the ocrd_lib.sh as a snippet library without "logic"?

@bertsky
Copy link
Member Author

bertsky commented Jun 29, 2023

Don't you think it's a better way to customize the global function post_validate_workdir in the file ocrd_lib.sh than in any implementation file or do you see the ocrd_lib.sh as a snippet library without "logic"?

I do see ocrd_lib.sh as a library of sorts. If we wanted to differentiate various validation options, then we should indeed handle this inside ocrd_lib.sh, but for the moment I don't see the need (and validation can get quite complex, so OCR-D should IMO encapsulate all of it).

@markusweigelt
Copy link
Collaborator

needed as a stopgap measure; currently needed because we must wait for adoption of OCR-D/core#1066

After merge we must surely adapt our script in Kitodo.Production as well?

@bertsky
Copy link
Member Author

bertsky commented Jul 3, 2023

After merge we must surely adapt our script in Kitodo.Production as well?

No, IMO it's enough to wait for the next ocrd_all release, since I have fixed the remaining processors now, they just need to be merged (which will likely happen sooner than our users updating their Kitodo).

@markusweigelt markusweigelt merged commit ed69e31 into main Jul 3, 2023
@markusweigelt markusweigelt deleted the skip-validation branch July 3, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants