Svxreflector list certs (signed and pending) #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd pending certificates - Refactored ctrlPtyDataReceived to send information to the client that is relevant for the command issued instead of just cout - Added getAllCerts() to retrieve all available certificates in a vector of CertInfo so that it can be consumed by other parts of the application if needed. - Added toString to Async::SslX509 class to return the certificate information as a string, and refactored print() to use toString() method instead.
Fixed the certificate ignoring own reflector certificate to use the configured COMMON_NAME
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't had the chance to test this branch in a RPi with an older Linux, I'm using std::partition_copy which requires C++17, not sure if it's actually faster (for large datasets) than calling getAllCerts() twice... Anyway, if it's an issue it's easy to fix.