-
Notifications
You must be signed in to change notification settings - Fork 42
Update schemas package to TypeScript #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…t reference in config
raucao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Left a few comments for improvements.
Everything seems to work fine, except for leaving channels:
sockethub:middleware:message Error: platform type leave not supported by xmpp platform. (types: credentials, connect, update, send, join, query, request-friend, remove-fri
end, make-friend)
sockethub:middleware:message at Array.<anonymous> (/home/basti/src/sockethub/sockethub/packages/server/dist/middleware/validate.js:46:33)
That's actually really cool that it fails "cleanly" with |
|
@raucao all your points have been addressed, ready for review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! 👍
Schemas platform is now all in TypeScript, improved build process to the
distfolder includes typing, schemas and json schemas for each import in TS or JS code.Depends on PRs #709 and #704