Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@silverbucket
Copy link
Member

Schemas platform is now all in TypeScript, improved build process to the dist folder includes typing, schemas and json schemas for each import in TS or JS code.
Depends on PRs #709 and #704

@silverbucket silverbucket requested review from galfert and raucao March 20, 2022 17:35
@silverbucket silverbucket self-assigned this Mar 20, 2022
@silverbucket silverbucket changed the title Update schemas platform to TypeScript Update schemas package to TypeScript Mar 20, 2022
Copy link
Contributor

@raucao raucao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Left a few comments for improvements.

Everything seems to work fine, except for leaving channels:

  sockethub:middleware:message Error: platform type leave not supported by xmpp platform. (types: credentials, connect, update, send, join, query, request-friend, remove-fri
end, make-friend)                                                                                                                                                            
  sockethub:middleware:message     at Array.<anonymous> (/home/basti/src/sockethub/sockethub/packages/server/dist/middleware/validate.js:46:33)  

@silverbucket
Copy link
Member Author

Code LGTM. Left a few comments for improvements.

Everything seems to work fine, except for leaving channels:

  sockethub:middleware:message Error: platform type leave not supported by xmpp platform. (types: credentials, connect, update, send, join, query, request-friend, remove-fri
end, make-friend)                                                                                                                                                            
  sockethub:middleware:message     at Array.<anonymous> (/home/basti/src/sockethub/sockethub/packages/server/dist/middleware/validate.js:46:33)  

That's actually really cool that it fails "cleanly" with leave because the platform schema doesn't define it in it's schema. Because it shows that the work in tightening up the schema validation works (eg. it doesn't fail unexpectedly and it doesn't sloppily succeed when it wasn't defined in the schema).

@silverbucket
Copy link
Member Author

@raucao all your points have been addressed, ready for review again.

Copy link
Contributor

@raucao raucao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 👍

@silverbucket silverbucket changed the base branch from sockethub-as-meta to master April 5, 2022 07:47
@silverbucket silverbucket merged commit a412176 into master Apr 5, 2022
@silverbucket silverbucket deleted the schemas-typescript branch December 14, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kredits-2 Medium contribution scope:schemas Issues related to Schemas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants