Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix property check #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
silverbucket merged 1 commit into from
May 10, 2022
Merged

Fix property check #733

silverbucket merged 1 commit into from
May 10, 2022

Conversation

@silverbucket
Copy link
Member

@silverbucket silverbucket commented May 10, 2022 •
edited
Loading

This should finally resolve #726 there was a second check of the same type of approach I totally overlooked.

@nx-cloud
Copy link

nx-cloud bot commented May 10, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2f6f3f8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@silverbucket silverbucket added this to the Hyperchannel Alpha milestone May 10, 2022
@silverbucket silverbucket added type:bug kredits-1 Small contribution labels May 10, 2022
@silverbucket silverbucket self-assigned this May 10, 2022
@silverbucket silverbucket requested a review from raucao May 10, 2022 07:44
@raucao
Copy link
Contributor

raucao commented May 10, 2022

Yay:

  sockethub:validate:-xLpGHcq21_rGG5MAAAB applying schema validation for message +0ms
  sockethub:middleware:message Error: /actor: must have required property 'type'
  sockethub:middleware:message     at Array.<anonymous> (/home/basti/src/sockethub/sockethub/packages/server/dist/middleware/validate.js:41:22)
  sockethub:middleware:message     at next (/home/basti/src/sockethub/sockethub/packages/server/dist/middleware.js:43:43)
  sockethub:middleware:message     at Array.expandActivityStream (/home/basti/src/sockethub/sockethub/packages/server/dist/middleware/expand-activity-stream.js:28:13)
  sockethub:middleware:message     at next (/home/basti/src/sockethub/sockethub/packages/server/dist/middleware.js:43:43)
  sockethub:middleware:message     at Socket.<anonymous> (/home/basti/src/sockethub/sockethub/packages/server/dist/middleware.js:49:13)
  sockethub:middleware:message     at Socket.emit (events.js:376:20)
  sockethub:middleware:message     at Socket.emitUntyped (/home/basti/src/sockethub/sockethub/packages/server/node_modules/socket.io/dist/typed-events.js:69:22)
  sockethub:middleware:message     at /home/basti/src/sockethub/sockethub/packages/server/node_modules/socket.io/dist/socket.js:465:39
  sockethub:middleware:message     at processTicksAndRejections (internal/process/task_queues.js:77:11) +0ms

raucao
raucao approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@raucao raucao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@silverbucket silverbucket merged commit 8161f89 into master May 10, 2022
@silverbucket silverbucket deleted the bugfix/schema-propcheck branch May 10, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raucao raucao raucao approved these changes

Assignees

@silverbucket silverbucket

Labels

kredits-1 Small contribution

Projects

None yet

Milestone

Hyperchannel Alpha

Development

Successfully merging this pull request may close these issues.

Sockethub shutting down instead of handling exception

3 participants

@silverbucket @raucao