-
Notifications
You must be signed in to change notification settings - Fork 46
v1.1.1 #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v1.1.1 #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anlegen der aframe-spezifischen Dateien, sowie erstellen von Variablen (canvasId, visMode) für switch statements in Application.js. Ablauf in der Application.js funktioniert ungefähr bis zur activateController-Funktion. Test Setup "blank.js: enthält inzwischen zu Testzwecken den SearchController und DefaultLogger. AframeActionController: bubble-canceling auskommentiert, um Navigation zu erlauben. AframeCanvasManipulator.initialize() zur Zeit leer und daher Fehlerfrei.
searchController loads long at initialization
-FlyToEntity-function not working yet -AframeActionController working with some workarounds -AframeCanvasMarkController working
-FlyToEntity-function not working yet -AframeActionController working with some workarounds -AframeCanvasMarkController working
…' into feature/aframe-canvasManipulator
add ids, remove script tag, adopt a-entity and a-scene to ui requirements
Feature/aframe canvas manipulator
-AframeCanvas(-Filter/-Select)Controller working -filter functions can be used via PackageExplorerController -new setup file "aframe.js" will be used for further testing instead of "blank.js" and activates the new Controllers
Select-/FilterController for Aframe
also: - fixed a bug where multiple hoverEvents were emitted - aframe.js updated - jqxProgressbar added to aframe.html
Removed unused aframe controllers
- added to aframe.html also: (un-)highlightEntity created for aframe
This controller got its own file, because the original specified it's own eventListeners on multiPart and canvas. This version subscribes for actions.hover/unhover instead.
AframeActionController.js now adds cursor coordinates as attributes .layerX and .layerY to "mouseenter" and "mouseleave" events. The cursors position gets stored on every "mousemove" event.
AframeActionController.js now adds cursor coordinates as attributes .layerX and .layerY to "mouseenter" and "mouseleave" events. The cursors position gets stored on every "mousemove" event.
Development
- testing revealed some bugs and deviating behaviors of the AframeCanvasManipulator. These seem to be fixed for now - AframeActionController emitted a second "mouseup" event object with canvas as target which is now filtered out
- testing revealed some bugs and deviating behaviors of the AframeCanvasManipulator. These seem to be fixed for now - AframeActionController emitted a second "mouseup" event object with canvas as target which is now filtered out
AframeCanvasManipulator: -missing functions work now -problems occure when flyToEntity is called by the controller -functions work because canvasController has access to the exact camera object specified by aframe-orbit-camera-component.js -this is achieved by storing the object during its initialization into the global variable globalCamera (definition in aframe.html) added file camera-beta: -adds the line "globalCamera = this" to the aframe-orbit-camera-component aframe.html: -defines the globalCamera variable ResetViewController: -now calls the reset function of the canvasManipulator instead of executing the functions body on its own -is now compatible with aframes canvasManipulator
Final changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features:
new backend (generator2) with increased performance and lower memory usage
migration to docker-based micro service architecture
preliminary UI support for A-Frame